RockteMQ-AI commented on issue #1226: URL: https://github.com/apache/rocketmq-dashboard/issues/1226#issuecomment-5213248539
**Issue Evaluation** Category: `enhancement` | Status: **Evaluated** **Feasibility:** feasible (with careful implementation) **Scope:** `DefaultMQAdminExt` connection cache, Aliyun OpenAPI client cache, lifecycle management layer **Compatibility:** No breaking changes if lease-based eviction is added incrementally This is a well-structured design proposal. The concern about racing in-flight requests during eviction is valid — the current `ConcurrentHashMap` + immediate `shutdown`/`close` pattern can indeed cause request failures. **Assessment:** - The lease/reference-count approach is the right direction for safe eviction - Wrapping cached clients with last-access metadata enables idle-based policies - Keeping forced invalidation on endpoint/credential mutations as an explicit lifecycle transition is good design - Testing concurrent acquire/evict paths is essential and should use stress tests with randomized timing This would benefit from a design document or RFC before implementation, given the concurrency complexity. --- *Automated evaluation by github-manager-bot* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
