RockteMQ-AI commented on issue #1323: URL: https://github.com/apache/rocketmq-clients/issues/1323#issuecomment-5213693447
**Issue Evaluation** Category: `type/bug` | Status: **Confirmed** Excellent bug report with clear root cause analysis and fix. **Root Cause:** PR #1253 added a special branch for `MESSAGE_NOT_FOUND` to downgrade the log level from ERROR to DEBUG, but forgot to call `cli.doAfter()` in that branch. This leaks the `inflightReceiveRequestCount` counter, causing `GracefulStop()` to always wait the full timeout. **Impact:** - Every PushConsumer shutdown takes a fixed ~24s (requestTimeout + longPollingTimeout + 1s) - Inflight counter grows unbounded during idle periods - Affects Go SDK v5.1.4+ (regression from v5.1.3) **Severity:** Medium — affects shutdown latency, not message delivery correctness **Fix Assessment:** The suggested one-line fix (call `doAfter` with `MessageHookPointsStatus_OK` in the `isNoNewMessage` branch) is correct and minimal. This restores the counter decrement while preserving the log level improvement from PR #1253. Ready for maintainer review and merge. --- *Automated evaluation by github-manager* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
