RockteMQ-AI commented on issue #1237: URL: https://github.com/apache/rocketmq-dashboard/issues/1237#issuecomment-5215151067
**Issue Evaluation** Category: `bug` | Status: **Confirmed** The reported issue has been verified against the current codebase on the `rocketmq-studio` branch. **Root Cause:** `InstanceService.createApacheInstance()` (line ~98) validates `name` and `endpoint` but does not validate `type`. The `rmq_instance.type` column is `NOT NULL` in the schema, so a request without `type` passes validation and fails at the persistence layer with an unstructured database error instead of a clean HTTP 400. **Impact:** Clients receive an opaque 500 error from the database layer instead of a meaningful validation error. This makes API debugging harder and violates the principle of fail-fast validation. **Severity:** medium **Affected files:** - `InstanceService.java:98` — `createApacheInstance()` missing type validation - `schema.sql:26` — `type` column is `NOT NULL` An automated fix proposal can be generated. Reply `/approve` to proceed with PR generation. --- *Automated evaluation by RockteMQ-AI* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
