tju-yxq opened a new pull request, #1429: URL: https://github.com/apache/rocketmq-dashboard/pull/1429
## What is the purpose of the change Fixes #1428 `getAllMasterBrokerAddrs()` returned all brokers from the entire NameServer topology. Topic and consumer group operations pushed config to all brokers across all clusters instead of just the target cluster. ## Brief changelog - **`RocketMQAdminClientImpl.java`**: Added `getMasterBrokerAddrsForCluster()` that uses `clusterAddrTable` to filter brokers by cluster name. - **`RocketMQAdminClientImpl.java`**: Updated `createTopic`, `updateTopic`, and `createConsumerGroup` to use the cluster-scoped method. - Falls back to `getAllMasterBrokerAddrs()` when the cluster name is unknown or the cluster table is missing, preserving backward compatibility for single-cluster deployments. ## Verifying this change 1. Configure a NameServer with two clusters (clusterA, clusterB). 2. Create a topic targeting clusterA. 3. Before fix: topic appears on clusterB brokers too. 4. After fix: topic only appears on clusterA brokers. - [x] Make sure there is a Github issue filed for the change. - [x] Format the pull request title like `[ISSUE #1428] ...`. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test to verify your logic correction. - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. - [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
