yx9o commented on PR #1175: URL: https://github.com/apache/rocketmq-dashboard/pull/1175#issuecomment-5241419958
> 感谢您提出的修改意见。经审核，我们希望在合并此更改之前缩小其范围：仪表盘的 Kubernetes 证书管理功能应仅限于**添加和编辑**证书记录。证书续订（无论是单个续订还是批量续订）不在仪表盘的范围内——续订属于集群端的证书工作流程（例如 cert-manager/ops pipelines），让仪表盘触发续订会创建一个缺乏相应权限和上下文的第二条控制路径。 > > 请据此修改： > > * 移除批量续订 API 和逻辑：`BatchRenewCertDTO`，，`BatchRenewCertResultVO`续订端点`K8sCertController`，续订处理`K8sCertService`，以及相关的测试和 API 文档条目。 > * 移除前端表格选择/批量确认/支持重试的失败处理`certs.tsx`以及相关的服务/API 新增功能。 > * 页面操作仅限于添加和编辑证书。有效期和 7/30/90 天筛选器可以保留，因为它们是只读显示辅助信息——如果您保留它们，请确认其含义。 > > 另请注意，此分支基于旧版本（[3c2639d](https://github.com/apache/rocketmq-dashboard/commit/3c2639df4e4e6487989b0ea3378dce569659be54)）；在进行修改时，请基于当前的 rocketmq-studio 进行重新构建。 Updated. Please review again when you have time. Thank you. > Thanks for the change. After review, we would like to narrow the scope before this can be merged: the dashboard's K8s certificate management should be limited to **adding and editing** certificate records. Certificate renewal (single or batch) is out of scope for the dashboard — renewal belongs to the cluster-side certificate workflow (e.g. cert-manager / ops pipelines), and having the dashboard trigger renewals creates a second control path without the proper authority or context. > > Please rework accordingly: > > * Remove the batch renewal API and logic: `BatchRenewCertDTO`, `BatchRenewCertResultVO`, the renewal endpoint in `K8sCertController`, the renewal handling in `K8sCertService`, and the related tests and API doc entries. > * Remove the frontend table selection / batch confirmation / retry-friendly failure handling in `certs.tsx` and the related service/API additions. > * Keep the page operations limited to adding and editing certificates. The expiry-status and 7/30/90-day filters may remain, since they are read-only display aids — please confirm this reading if you keep them. > > Also note that this branch is based on an old base ([3c2639d](https://github.com/apache/rocketmq-dashboard/commit/3c2639df4e4e6487989b0ea3378dce569659be54)); please rebase onto the current rocketmq-studio when reworking. Updated. Please review again when you have time. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
