youngkermit8-coder commented on PR #1508: URL: https://github.com/apache/rocketmq-dashboard/pull/1508#issuecomment-5246088981
Addressed the remaining non-blocking review suggestions in `04f862a`: - Added explicit coverage for `ap-shanghai-adc`, which must use the nearby-access endpoint. - Added fallback coverage for both `null` and empty region values. Validation: - `TencentCatalogServiceTest` and `TencentClientFactoryTest`: 6 tests passed - Checkstyle: 0 violations The full main-source compilation is still blocked by the unrelated base-branch errors tracked in #1502. I will rerun the complete Maven build as soon as that fix is merged and synchronized. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
