tju-yxq opened a new pull request, #1606:
URL: https://github.com/apache/rocketmq-dashboard/pull/1606

   ## What is the purpose of the change
   
   Fixes #1605
   
   `TencentInstanceProvider.getTopicConsumers()` only fetched 1 page (100 
consumers) without pagination. Topics with >100 consumer groups had their 
consumers silently dropped.
   
   ## Brief changelog
   
   - **`TencentInstanceProvider.java`**: Added a pagination loop to 
`getTopicConsumers()` matching the pattern already used by `listTopics()`. 
Iterates through all pages until fewer than `CONSUMER_PAGE_SIZE` results are 
returned.
   
   ## Verifying this change
   
   1. Create a Tencent topic with 150+ consumers.
   2. View topic detail page Consumers tab.
   3. Before fix: only 100 consumers shown.
   4. After fix: all consumers shown.
   
   - [x] Make sure there is a Github issue filed for the change.
   - [x] Format the pull request title like `[ISSUE #1605] ...`.
   - [x] Write a pull request description that is detailed enough.
   - [x] Write necessary unit-test.
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs 
checkstyle:checkstyle`.
   - [ ] If this contribution is large, please file an Apache Individual 
Contributor License Agreement.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to