yuluo-yx opened a new pull request, #1766:
URL: https://github.com/apache/rocketmq-dashboard/pull/1766

   ## What is the purpose of the change
   
   Fix JsonUtil so valid pretty-printed JSON and multiline String values reach 
Jackson unchanged. The previous preprocessing replaced line breaks with literal 
escape sequences, which invalidated structural JSON whitespace and mutated 
String values.
   
   Fixes #1760
   
   ## Brief changelog
   
   - Remove carriage-return and line-feed rewriting from `JsonUtil.string2Obj`.
   - Add regression coverage for pretty-printed JSON, multiline strings, valid 
escaped newlines, and invalid raw JSON string newlines.
   
   ## Verifying this change
   
   - JDK: Temurin 17.0.19
   - Backend-only Maven verification: `mvn -q compiler:compile 
compiler:testCompile -Dtest=<target> surefire:test`
   - `JsonUtilTest`: 2 tests, 0 failures, 0 errors
   - `mvn validate`: passed
   - `git diff --check`: passed
   - PR scope check: passed (2 files, 51 changed lines, one commit, base 
`master`)
   - Full lifecycle, integration, E2E, and container checks were not run 
because this five-PR workflow requires lightweight local verification and 
leaves heavyweight checks to upstream CI.
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily.
   
   - [x] Make sure there is a Github issue filed for the change. This PR 
addresses only that issue.
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException 
when host config not exist`. Each commit has a meaningful subject and body.
   - [x] Write a pull request description that explains what, how, and why.
   - [x] Write necessary unit tests to verify the logic correction.
   - [ ] Run the repository full basic, install, and integration command 
matrix. The focused backend checks above pass; heavyweight checks are delegated 
to upstream CI.
   - [ ] If this contribution is large, file an Apache Individual Contributor 
License Agreement.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to