1ASunny opened a new pull request, #10910:
URL: https://github.com/apache/rocketmq/pull/10910

   ### Which Issue(s) This PR Fixes
   
   - Fixes #10898
   
   ### Brief Description
   
   NettyEventExecutor.wakeup() now offers a private sentinel event after 
delegating to ServiceThread.wakeup(). This releases a worker blocked in the 
event queue's three-second poll so shutdown can observe the stopped flag 
immediately. The dispatch loop skips the sentinel by identity, leaving normal 
channel events unchanged.
   
   The regression coverage verifies both prompt shutdown while the executor is 
blocked in the timed poll and that the private wakeup sentinel is never 
dispatched to the channel listener.
   
   This PR supersedes #10909, which was accidentally opened from the wrong 
GitHub account and closed immediately. This version also adds explicit 
sentinel-dispatch coverage.
   
   ### How Did You Test This Change?
   
   - NettyRemotingAbstractTest: 7 tests passed.
   - Checkstyle passed with 0 violations.
   - SpotBugs passed with 0 issues.
   - git diff --check passed.
   - The full common + remoting suite was attempted on Windows with JDK 17, but 
did not complete because the existing RemotingServerTest#testInvokeAsync waits 
indefinitely in CountDownLatch.await(). The focused test class and unrelated 
compatibility test both pass.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to