tju-yxq commented on issue #1772: URL: https://github.com/apache/rocketmq-dashboard/issues/1772#issuecomment-5269386303
## Correction / closing as already fixed I re-checked this report against the current `rocketmq-studio` branch. The underlying bug is valid, but it has already been fixed on the base branch by #1652 (`01f629f1`, `fix(consumer): keep aggregated lag unknown when any queue is unknown`). That merged change updates `RocketMQMetadataProvider.getTopicConsumers()` so an `UNKNOWN` queue lag propagates to the aggregate instead of being summed, and it also adds regression tests: - `getTopicConsumersKeepsUnknownWhenAnyQueueLagIsUnknown()` - `getTopicConsumersStillSumsKnownQueueLags()` I also verified the focused regression test locally earlier: ```bash mvn -DskipTests=false -Dtest=RocketMQMetadataProviderTest#getTopicConsumersKeepsUnknownWhenAnyQueueLagIsUnknown test ``` Result: `BUILD SUCCESS`, `Tests run: 1, Failures: 0, Errors: 0, Skipped: 0`. Closing this issue because the current base branch already contains the tested fix. The later PR #1779 is now a dirty duplicate of the merged #1652 change and should not be merged separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
