Aias00 commented on PR #10798: URL: https://github.com/apache/rocketmq/pull/10798#issuecomment-5293767135
Addressed the review comments. The asynchronous failure path now unwraps CompletionException before the existing remoting error mapper runs, so MQBrokerException response codes and remarks are retained. The existing test suite already returns a completed ChannelFuture and verifies that no success response is written before the pending endTransaction future completes. Verified with: mvn -q -pl proxy -am -Dtest=TransactionActivityTest -Dsurefire.failIfNoSpecifiedTests=false test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
