yuluo-yx opened a new pull request, #2199:
URL: https://github.com/apache/rocketmq-dashboard/pull/2199

   ## What is the purpose of the change
   
   This PR consolidates three related runtime accuracy fixes, following the 
maintainer guidance in #2107. It replaces the closed one-off PRs #2146, #2157, 
and #2160 without reopening them.
   
   Dynamic metrics sources currently lose their configured authentication mode 
and infer it from whichever credentials are non-empty. This can send an 
Authorization header for `none` or choose Bearer when `basic` was configured. 
The Metrics Explorer also assumes provider samples are already ordered, which 
can draw a backwards line and report an older sample as the latest value. 
Finally, a DLQ resend that reaches the 5,000-message safety cap is reported as 
a complete success even though messages remain unprocessed.
   
   ## Brief changelog
   
   - propagate and strictly apply the configured metrics authentication mode, 
while retaining compatibility for static Prometheus configuration
   - sort numeric metric samples by timestamp before charting and selecting the 
latest value
   - mark hard-cap DLQ scans as truncated, return a partial outcome, and record 
truncation in the audit detail
   - add regression coverage for authentication headers, unordered samples, and 
5,001-message DLQ scans
   
   ## Verifying this change
   
   - `mvn -o -s /private/tmp/maven-settings-pr20.xml -Dmaven.compiler.proc=full 
-Dtest=MetricsServiceTest,MultiBackendMetricsSourceTest,PrometheusMetricsSourceTest,RocketMQDLQProviderTest,DLQServiceTest
 test` (74 tests passed)
   - `mvn -o -s /private/tmp/maven-settings-pr20.xml -DskipTests 
checkstyle:check` (0 violations)
   - `npm test -- --run src/components/__tests__/MetricsExplorer.test.tsx` (12 
tests passed)
   - ESLint and Prettier checks passed for the changed frontend files
   - `npm run build` passed
   - `git diff --check` passed
   
   Fixes #2141
   Fixes #2152
   Fixes #2155
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to