btlqql opened a new pull request, #2243: URL: https://github.com/apache/rocketmq-dashboard/pull/2243
## Summary - canonicalize every accepted metrics backend spelling before persistence - keep VictoriaMetrics on its dedicated query paths instead of silently falling back to Prometheus - trim, validate, and stably deduplicate instance bindings at the request boundary - add focused backend and DTO regression coverage ## Problem The settings DTO accepts the space-separated VictoriaMetrics spelling, while backend lookup previously did not. A configuration could therefore pass validation but query the wrong API path. Instance bindings were also persisted verbatim, so surrounding whitespace made a valid instance fail later exact membership checks. ## Verification - `mvn -Dtest=MetricsBackendTypeTest,DataSourceDTOTest,SettingsServiceTest,MetricsServiceTest,MultiBackendMetricsSourceTest test` (77 tests passed) - `mvn checkstyle:check` (0 violations) - `mvn -DskipTests package` (BUILD SUCCESS) - `git diff --check` A separate full local test run reached 1,201 tests; five existing CLI environment cases failed because the shell CLI is unavailable or returned the fixture timeout/status responses. None of those tests or code paths are changed by this PR. Closes #2242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
