RockteMQ-AI commented on issue #2242: URL: https://github.com/apache/rocketmq-dashboard/issues/2242#issuecomment-5303316783
**Issue Evaluation** Category: `bug` | Status: **Confirmed** The reported issue is valid. The settings API accepts space-separated forms like `victoria metrics` but `MetricsBackendType.fromProviderType` does not recognize them, causing silent fallback to Prometheus paths. Additionally, `instanceIds` are stored without trimming/deduplication, leading to query mismatches. **Root Cause:** Missing canonicalization at the DTO boundary — provider type strings and instance ID bindings are persisted as-is without normalization. **Impact:** Saved configurations silently use wrong backend paths; instance-scoped queries fail for normalized IDs. **Severity:** Medium — configuration correctness issue, no data loss. **Proposed fix:** Canonicalize provider types (trim, normalize separators) and instance bindings (trim, reject blanks, deduplicate preserving order) at the DTO boundary. Keep backend lookup compatible with common separator variants. An automated fix proposal can be generated. Reply `/approve` to proceed with PR generation. --- *Automated evaluation by RockteMQ-AI* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
