RockteMQ-AI commented on issue #2281: URL: https://github.com/apache/rocketmq-dashboard/issues/2281#issuecomment-5311300425
**Issue Evaluation** Category: `enhancement` | Status: **Evaluated** **Feasibility:** Feasible **Scope:** DLQ group listing API (likely `DLQController` or `DeadLetterQueueService`) **Compatibility:** API change (adds pagination parameters); requires UI update This addresses a classic N+1 query problem in the DLQ discovery path. The current implementation fetches all topics, filters DLQs, then calls `examineTopicStats` for each one before returning an unbounded list. **Assessment:** - The problem is valid: large clusters with many DLQ groups will cause excessive Admin RPCs - The proposed solution (pagination + deterministic sorting + bounded stats lookups) is the correct approach - Clear scope definition (excludes DLQ resend semantics) helps focus the implementation **Recommendation:** Proceed with implementation. Consider: 1. Default page size should be reasonable (e.g., 20-50) to avoid overwhelming the UI 2. Sorting should be by DLQ group name for consistency 3. The `PageResult<DLQGroupVO>` response should include total count for UI pagination controls 4. Update both API and UI in the same PR to maintain consistency --- *Automated evaluation by RockteMQ-AI* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
