RockteMQ-AI commented on issue #2279: URL: https://github.com/apache/rocketmq-dashboard/issues/2279#issuecomment-5311301826
**Issue Evaluation** Category: `enhancement` | Status: **Evaluated** **Feasibility:** Feasible **Scope:** Client connection listing API (`GET /api/clients`) **Compatibility:** API change (adds pagination parameters); requires UI update This addresses another unbounded response issue in the Studio client connection listing. The current implementation scans producer tables across all brokers and iterates subscription groups without any pagination or bounds. **Assessment:** - The problem is valid: large clusters can produce responses with thousands of connections - The proposed solution (pagination + deterministic ordering) is appropriate - The note about follow-up work (Proxy Admin capability) shows good forward thinking **Recommendation:** Proceed with implementation. Consider: 1. Default page size should balance completeness with performance (e.g., 50-100 connections per page) 2. Deterministic ordering should be by client ID or connection ID for consistency 3. The `PageResult<ClientConnectionVO>` should include total count and current page info 4. Consider adding optional filters (e.g., by producer/consumer type, by instance) in a follow-up 5. Update regression tests to verify pagination behavior with mock large datasets --- *Automated evaluation by RockteMQ-AI* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
