btlqql commented on PR #1374: URL: https://github.com/apache/rocketmq-dashboard/pull/1374#issuecomment-5329702670
Thanks for the detailed review. The latest commit addresses the requested schema refresh and follow-ups: **Must fix** 1. Regenerated the V1 baseline from the current Studio schema, including `rmq_acl_user.white_remote_address`. 2. Aligned `rmq_instance` with current trunk (`vendor` nullable, `region_id` at 128 characters, and current index definitions/names). 3. Updated V2 to add or widen the missing columns safely and to guard indexes using the current names, including the existing-volume migration path. **Minor** - Renamed the integration test to `upgradesExistingDatabaseAndRemainsIdempotentTest`. - Updated the root and deploy documentation to state that the legacy `deploy/mysql/upgrade-*.sql` scripts are superseded by Flyway. The refreshed integration test also asserts the ACL allowlist column and the 128-character region width. Ready for re-review when convenient. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
