lizhimins commented on PR #2543:
URL:
https://github.com/apache/rocketmq-dashboard/pull/2543#issuecomment-5408864655
Thanks for the contribution. After review we are not taking instance-list
pagination in this project: per an explicit product convention, each user has a
limited number of instances (tens at most), so the instance list intentionally
returns the full set without server-side or client-side pagination
(`pagination={false}`). This PR also bypasses the established backend ordering
contract (APACHE instances by name, then cloud vendors by region → instance id,
unified in `InstanceService.listInstances`) via `orderByAsc("id")`, and adds
unused `countAll()`/`count()` repository methods. Closing accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
