RockteMQ-AI commented on issue #2634:
URL: 
https://github.com/apache/rocketmq-dashboard/issues/2634#issuecomment-5437482470

   **Issue Evaluation**
   
   Category: `bug` | Status: **Confirmed**
   
   The reported issue has been verified against the current codebase.
   
   **Root Cause:** In `consumer.tsx`, `loadGroupSettings` (line 419) is an 
async function that:
   1. Sets `settingsGroup` to the target group (line 421)
   2. Makes an async API call `getConsumerGroupSettings` (line 424)
   3. On response, applies `settingsForm.setFieldsValue(settings)` (line 425)
   
   If the user switches to a different consumer group before the API call 
returns, the stale response from the **previous** group is applied to the form 
that now belongs to the **new** group. There is no guard checking whether the 
response still matches the current `settingsGroup`.
   
   **Impact:** User opens settings for group A, quickly switches to group B. 
Group A's settings response arrives late and overwrites group B's form fields. 
User saves, inadvertently applying group A's values to group B.
   
   **Severity:** Medium — silent data corruption of consumer group 
configuration.
   
   **Fix direction:** Capture the group name at fetch time and verify it 
matches the current `settingsGroup` before calling `setFieldsValue`. 
Alternatively, use an AbortController to cancel in-flight requests when the 
group changes.
   
   An automated fix proposal can be generated. Reply `/approve` to proceed with 
PR generation.
   
   ---
   *Automated evaluation by RockteMQ-AI*
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to