RockteMQ-AI commented on issue #10978: URL: https://github.com/apache/rocketmq/issues/10978#issuecomment-5438070174
**Issue Evaluation** Category: `type/enhancement` | Status: **Evaluated** **Feasibility:** Feasible **Scope:** `module/client` (Message.java), Maven dependency declarations **Compatibility:** No breaking changes — pure metadata addition and dependency exclusion This is a well-specified enhancement with two independent parts: 1. **@Nullable annotations** — Adding `@Nullable` to the seven getters (`getTags()`, `getKeys()`, `getProperty()`, `getUserProperty()`, `getBuyerId()`, `getProperties()`, `getTransactionId()`) is a low-risk, high-value change. It improves IDE warnings, prevents silent NPEs, and enables proper Kotlin interoperability. The reference to the unresolved #1453 (2019) shows this is a long-standing pain point. 2. **kotlin-stdlib transitive leak** — Extending the existing `okio-jvm` exclusion to cover the `opentelemetry-exporter-sender-okhttp` → `okhttp` path is consistent with the project's existing dependency hygiene policy. Pure-Java consumers should not receive `kotlin-stdlib` transitively. Both changes are straightforward and can be addressed in a single PR or split into two focused PRs. --- *Automated evaluation by RockteMQ-AI* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
