tju-yxq commented on PR #2642: URL: https://github.com/apache/rocketmq-dashboard/pull/2642#issuecomment-5445641395
Addressed the review suggestions in commit 79db2407: added class-level Javadoc for LeaseHeartbeat and clarified that the persist-time tryAcquire() check is intentional defense-in-depth against a heartbeat race. No runtime behavior changed. Re-ran the focused server tests from server/: CollectorSchedulerTest and MybatisPlusAlertCollectionLeaseTest pass (exit 0); git diff --check is clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
