wang-jiahua commented on code in PR #10981:
URL: https://github.com/apache/rocketmq/pull/10981#discussion_r3877220564
##########
broker/src/main/java/org/apache/rocketmq/broker/processor/PopReviveService.java:
##########
@@ -426,12 +424,11 @@ protected void consumeReviveMessage(ConsumeReviveObj
consumeReviveObj) {
}
}
} else if
(PopAckConstants.BATCH_ACK_TAG.equals(messageExt.getTags())) {
- String raw = new String(messageExt.getBody(),
StandardCharsets.UTF_8);
if (brokerController.getBrokerConfig().isEnablePopLog()) {
- POP_LOGGER.info("reviveQueueId={}, find batch ack,
offset:{}, raw : {}", messageExt.getQueueId(), messageExt.getQueueOffset(),
raw);
+ POP_LOGGER.info("reviveQueueId={}, find batch ack,
offset:{}, raw : {}", messageExt.getQueueId(), messageExt.getQueueOffset(), new
String(messageExt.getBody(), StandardCharsets.UTF_8));
Review Comment:
Same fix as above — guarded with `isInfoEnabled()` (commit f2696b9).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
