wang-jiahua commented on code in PR #10566:
URL: https://github.com/apache/rocketmq/pull/10566#discussion_r3878051183
##########
store/src/main/java/org/apache/rocketmq/store/ConsumeQueue.java:
##########
@@ -1271,7 +1279,13 @@ public void initializeWithOffset(long offset, long
minPhyOffset) {
// transientStorePool is null, only need set wrote position here
MappedFile mappedFile = mappedFileQueue.getLastMappedFile(offset *
ConsumeQueue.CQ_STORE_UNIT_SIZE, true);
- fillPreBlank(mappedFile, offset * ConsumeQueue.CQ_STORE_UNIT_SIZE);
+ if (mappedFile != null && mappedFile.hold()) {
+ try {
+ fillPreBlank(mappedFile, offset *
ConsumeQueue.CQ_STORE_UNIT_SIZE);
+ } finally {
+ mappedFile.release();
+ }
+ }
Review Comment:
Re-confirmed on the current branch: `initializeWithOffset()` now logs an
error and aborts (no `fillPreBlank()`, no `flush(0)`) when the mapped file
cannot be created or held, so a file availability problem no longer looks like
a successful initialization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
