tju-yxq commented on PR #2697: URL: https://github.com/apache/rocketmq-dashboard/pull/2697#issuecomment-5454868475
Implementation update for `0ef91d8406e38459551e8b0711c7a55bfb512bad`: - Added `NativeAlertEvaluationService` with a separate `REQUIRES_NEW` transaction for each rule/sample evaluation. - Kept rule loading once per domain and preserved aggregation, state transitions, suppression, lifecycle persistence, and notification enqueue behavior. - Runtime failures now roll back the current evaluation and allow later rules/samples to run; `Error` is intentionally not swallowed. - Production diff: 170 added / 101 deleted lines across the two production classes (271 changed production lines; 154 new production lines in the evaluation service). - Regression coverage includes aggregation failure continuation, alert persistence failure continuation, transaction propagation, and fatal `Error` propagation. - Local verification: `mvn -q '-Dtest=NativeAlertProcessorTest,CollectorSchedulerTest,StudioApplicationTest' test` passed; full `mvn -DskipTests=false test` passed with 1792 tests, 0 failures, 0 errors, 0 skipped; `git diff --check` passed. The repository CI run is currently a workflow `startup_failure` with zero jobs (`33188571514`), so there is no Backend/Frontend/Docker test result to report. This is the same repository-level Actions startup/policy failure seen on the other open PRs, not a code-test failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
