unbridled-41 commented on PR #2835: URL: https://github.com/apache/rocketmq-dashboard/pull/2835#issuecomment-5467777202
Force-pushed the branch with two additions found while auditing this PR's coverage (no behavior change to the accepted validation path): - **Test for the second entry point**: the validation was wired into both `resendMessages` and `resendSelectedMessages`, but the new tests only exercised the time-range entry. Added `resendSelectedMessagesRejectsSystemTopicAsTarget` proving the selected-resend entry enforces the same guard before any scan/dispatch. - **Exception grading**: while verifying the target, a failure of `fetchAllTopicList` (e.g. nameserver unreachable) propagated as a raw remoting exception. It is now graded to `BusinessException(502, "Failed to verify targetTopic...")`, matching the scan-failure convention in the same file. Covered by `resendMessagesFailsGracefullyWhenTopicListCannotBeRead`. `RocketMQDLQProviderTest`: 26 tests, all green (was 24). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
