yyqdbngt opened a new pull request, #2847:
URL: https://github.com/apache/rocketmq-dashboard/pull/2847

   ## Summary
   - compare the LLM API base URI scheme with `Locale.ROOT` instead of the host 
default locale
   
   ## Why
   `uri.getScheme().toLowerCase()` applies the JVM's default locale. Under a 
Turkish-locale JVM, a scheme containing `I` (e.g. a user-typed `HTTPS` variant 
or any future scheme letter) lowercases to the dotless `ı`, so the 
`http`/`https` equality check silently rejects a valid base URL with "LLM API 
base URL is invalid". The same class already normalizes provider names with 
`Locale.ROOT` in `normalize(...)`, so this aligns the scheme check with the 
established convention.
   
   ## Testing
   - `mvn -q -f server/pom.xml -Dtest=OpenAiCompatibleLlmClientTest test` — 
Tests run: 23, Failures: 0, Errors: 0 (includes new 
`completeShouldAcceptUppercaseSchemeApiBaseRegardlessOfHostLocale`)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to