RockteMQ-AI commented on code in PR #2883:
URL:
https://github.com/apache/rocketmq-dashboard/pull/2883#discussion_r3903695827
##########
server/src/main/java/org/apache/rocketmq/studio/ops/alert/NotificationOutboxService.java:
##########
@@ -226,6 +226,21 @@ private static String normalizeTrim(String value) {
return StringUtils.hasText(value) ? value.trim() : null;
}
+ /**
+ * Maps a stored status to the known outbox lifecycle. Legacy or partially
written rows must
+ * not break the delivery listing, so unknown values surface as FAILED for
manual attention.
+ */
+ private static NotificationOutboxStatus parseStoredStatus(String status) {
+ if (!StringUtils.hasText(status)) {
+ return NotificationOutboxStatus.FAILED;
+ }
+ try {
Review Comment:
**[Info]** Consider adding a `log.warn("Unknown outbox status mapped to
FAILED: {}", status)` inside the catch block. Silent mapping is correct
behaviorally, but a warning helps operators detect data-integrity drift (e.g. a
new enum value added to the DB but not to `NotificationOutboxStatus`) during
troubleshooting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
