lizhimins commented on PR #1374: URL: https://github.com/apache/rocketmq-dashboard/pull/1374#issuecomment-5505555217
Thanks for this work — we agree Flyway is the right direction for schema migrations. However, this PR was opened against a much older baseline, and the `rocketmq-studio` branch is under active development with the schema moving fast since then: the alerting subsystem tables (#2533), `result_snapshot` (#2839) and several other columns/indexes were added after this branch was cut, so `V1__baseline.sql` is now significantly out of date and a Flyway-managed fresh database would be missing tables that the MyBatis-Plus entities expect. Rather than stacking rebase work on this stale branch, we're closing it — please open a **new PR** based on the latest `rocketmq-studio` that: 1. Regenerates `V1__baseline.sql` from the current `server/src/main/resources/db/schema.sql` (keep `schema.sql` as the dev/H2 source of truth); 2. Keeps the idempotent `V2__upgrade_legacy_schema.sql` approach for existing numeric-ID volumes; 3. Addresses the overlap with `AlertSchemaMigration` (the ApplicationRunner introduced in #2533) — Flyway should supersede it, so plan to retire or fold that runner into the migration scripts. Looking forward to the refreshed submission. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
