RockteMQ-AI commented on issue #11000: URL: https://github.com/apache/rocketmq/issues/11000#issuecomment-5522594344
**Issue Evaluation** Category: `type/enhancement` | Status: **Evaluated** **Feasibility:** Feasible **Scope:** Proxy module (`SendMessageActivity` in gRPC v2 producer path) **Compatibility:** No breaking changes — purely internal refactoring. This is a well-motivated refactoring request. Extracting the user-property validation logic from `buildMessageProperty()` into a dedicated `protected void checkUserProperties(Map<String, String>)` method provides a narrow, stable extension point for deployments that need custom property validation rules. The current design forces downstream users to override the entire `buildMessageProperty()` method (which handles tag/keys, transaction properties, delay/deliver-timestamp, priority, message group, lite topic, trace context, etc.) just to customize one validation block. This creates unnecessary maintenance burden and divergence risk. **Recommendation:** Accept. The change is low-risk, improves extensibility, and follows the Open/Closed Principle. --- *Automated evaluation by RockteMQ-AI* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
