RockteMQ-AI commented on issue #3148: URL: https://github.com/apache/rocketmq-dashboard/issues/3148#issuecomment-5546422358
**Issue Evaluation** Category: `enhancement` | Status: **Evaluated** Thank you for the detailed proposal. This is a well-scoped feature request for a read-only alert rule portfolio review. **Feasibility:** Feasible — the existing complete rule-list API contract provides the data foundation. The detection rules you listed (duplicate signatures, orphaned instances, missing notification channels, fully-disabled scopes) are all derivable from client-side analysis of the rule inventory without requiring backend changes. **Scope:** Primarily affects the alert management frontend module. Key implementation areas: - Data layer: consume the existing full rule-list endpoint, build in-memory indexes for cross-page analysis - Detection engine: implement the five condition checks (signature dedup, name dedup, missing channels, stale instances, all-disabled scopes) - UI: new read-only review view with filters, issue/rule perspectives, CSV export, and i18n support - Tests: focused unit tests for each detection condition **Compatibility:** No breaking changes — this is additive. Different thresholds are correctly excluded from conflict detection as you specified. **Notes:** - The "evidence-backed" constraint (no heuristic conflict detection) is a good design decision that keeps the review actionable - Cross-page analysis is the core value proposition — worth highlighting in the PR description - Consider whether "instances that no longer exist" should be checked against the live cluster registry or a cached snapshot This is a solid enhancement. A PR implementing this would be welcome. --- *Automated evaluation by RockteMQ-AI* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
