unbridled-41 commented on PR #10993:
URL: https://github.com/apache/rocketmq/pull/10993#issuecomment-5547356503
Evidence chain re-verified on 2026-09-05 (JDK 21, Maven 3.8.7), anchored to
commits:
- **After fix** — fix commit 29d7ce294 (the develop-merge on the branch is
from `update-branch`, no code change):
`mvn -pl broker test -Dtest=TransactionalMessageServiceImplTest` → `Tests
run: 9, Failures: 0, Errors: 0, Skipped: 0`, including
`testEscapeRetryBackoffMillisIsExponential` asserting
`escapeRetryBackoffMillis(i) == 100L * (1L << i)` for i = 1..10.
- **Before fix** — base commit e348efa66, call site
`TransactionalMessageServiceImpl.java:253`: `Thread.sleep(100L * (2 ^
escapeFailCnt))`. The new test cannot compile against the base (the helper is
extracted by this PR), so the defect is shown at formula level (evaluated with
jshell on the same JDK):
- old expression `100L * (2 ^ i)` for i = 1..10 → `300 0 100 600 700 400
500 1000 1100 800` ms — non-monotonic, 0 ms on the second failure (backoff
defeated);
- fixed expression `100L * (1L << i)` → `200 400 800 1600 3200 6400 12800
25600 51200 102400` ms.
- **CI**: all 10 checks green on this PR after re-triggering the workflows
via branch update (maven-compile linux/macos/windows, bazel, CodeQL, coverage,
license, misspell).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
