tju-yxq commented on PR #3710: URL: https://github.com/apache/rocketmq-dashboard/pull/3710#issuecomment-5584353586
Thanks for the review — both issues are fixed in 6c940d4f (also rebased onto the current `rocketmq-studio`): 1. **Undefined `asLong` helper (compile break)** — the repository now uses the existing `JdbcRowValues.longValueOrZero(row, key)` utility from `org.apache.rocketmq.studio.common.util` to read the aggregate columns. This also makes the lookup robust to JDBC drivers that return different label casing or stringify aggregates. 2. **Header count going stale after acknowledgement** — `handleAck` now decrements the loaded summary's `unacknowledged` value locally when the acknowledge request succeeds, so the header updates immediately instead of waiting for the next page load. Added a regression test that acknowledges an alert and asserts the header goes from 3 to 2 without a reload. Validation on the rebased branch: - `mvn '-Dtest=AlertServiceTest,SystemAlertControllerTest,MybatisPlusAlertRepositoryTest' test` — 106 tests passed - `mvn checkstyle:check` — 0 violations - `npm test -- SystemAlertsPage.test.tsx --run` — 16 tests passed - `npm run lint -- --quiet` — 0 errors - `npm run build` — passed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
