unbridled-41 commented on PR #4172:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4172#issuecomment-5588026773
## Verification evidence
- **CI**: for this PR's head SHA `2ed2f4101e06f0c8547a6a744cebb92a16016822`:
`gh api /repos/apache/rocketmq-dashboard/actions/runs?head_sha=<sha>` returns
exactly one `CI (pull_request)` run with `conclusion=startup_failure`, and
`/commits/<sha>/check-runs` reports `total_count=0` — the upstream workflow
never starts (recent base-branch runs are also startup_failure), so nothing
here can pass or fail CI.
- **Red** (frontend, base `0a596661`, only the new test added): `npx vitest
run src/pages/instance/__tests__/ConsumerPage.test.tsx -t "passes the
subscription mode filter"` → `Tests 1 failed | 31 skipped`. Failure diff:
expected the last `listConsumerGroupPage` call to contain `"subscriptionMode":
"Pop"`, received `{instanceId, page: 1, pageSize: 20, search: undefined}` — the
mode is never sent.
- **Module tests (frontend)** after the fix: `npx vitest run
src/pages/instance/__tests__/ConsumerPage.test.tsx` → `Tests 32 passed (32)`
(31 pre-existing + 1 new).
- **Module tests (backend)** after the fix: `mvn -o test
-Dtest='RocketMQMetadataProviderTest,MetadataServiceTest,ConsumerGroupControllerTest,ToolGatewayServiceTest'`
→ `Tests run: 132, Failures: 0, Errors: 0, Skipped: 0`. New regressions:
`listConsumerGroupsPageShouldPushSubscriptionModeFilterIntoTheDatabaseQuery`
(asserts the SQL segment and bound parameter contain `message_model`/`Pop`),
`listConsumerGroupsPageShouldPassSubscriptionModeToTheProvider`,
`listConsumerGroupsPageShouldPassSubscriptionModeFilterThrough`; existing tests
updated to the new signature (null mode = unchanged behavior). One existing
test (`listConsumerGroupsPageShouldUseDatabasePaginationAndStableOrdering`)
failed during development only because its positional call now bound `"group"`
to the mode parameter — updated to the new signature, all green.
- **Full suite (web)** after the fix: `npx vitest run` → `Test Files 115
passed (115)`, `Tests 945 passed (945)` on the final run. One earlier run had
`ConsumerPage > shows group health diagnostics` fail (9485ms, load-related);
that test passes in isolation and in the full re-run — the documented
full-suite load flakiness on this untouched-except-tests file.
- **Build**: `npx tsc --noEmit` clean; eslint clean on the 3 changed web
files; `npm run build` → `✓ built in 12.18s`. Backend compiles clean via the
test run above (covers the CI backend-build compile step).
- **Diff self-check**: `git show 2ed2f410 --numstat` → 14 files, +146/−35:
backend 7 files (param threading + DB filter + default impls) + 4 test files;
web 3 files (API type +1, page +32/−16 net, test +28). No unrelated changes; no
behavioral change for callers that do not send the new optional parameter (AI
tool passes null explicitly).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
