unbridled-41 commented on PR #4175:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4175#issuecomment-5593295453
## Verification evidence
- **CI**: This PR's head SHA `abef8546154c4bb0a20b1090ba8ffc637e7bcc26` has
exactly one workflow run — `CI (pull_request)` with conclusion
`startup_failure`, 0 check-runs, combined status `pending`. Upstream's workflow
has been failing at startup for all branches (including `rocketmq-studio`
itself), so no CI signal is available; the suite was run locally instead.
- **Red-light actual output** (before the fix, same tests):
```
❯ src/pages/ops/__tests__/AlertsPage.test.tsx (24 tests | 2 failed)
× formats the last triggered timestamp instead of rendering the raw ISO
value
× interprets the last triggered timestamp as UTC, not the browser zone
```
- **Module tests**: `npx vitest run
src/pages/ops/__tests__/AlertsPage.test.tsx` → 24/24 passed after the fix.
- **Full suite + baseline**: `npx vitest run` → 945 tests, 944 passed, 1
failed (`ConsumerPage > shows group health diagnostics from subscriptions,
progress and clients`, untouched file). Pristine `rocketmq-studio` @ 0a596661
isolated run of that file/test passes, and the same isolated run with this
change applied passes (31 tests file-level) → load flakiness, not a regression.
- **Build**: `npx tsc --noEmit` clean; `npm run build` succeeded (8.25s) —
covers the type-check step of the CI build job.
- **Diff self-check** (`git show --numstat abef8546`):
`web/src/pages/ops/alerts.tsx` +4/−2,
`web/src/pages/ops/__tests__/AlertsPage.test.tsx` +13/−2; total 2 files,
+17/−4. No unrelated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
