unbridled-41 commented on PR #4177:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4177#issuecomment-5593493291
## Verification evidence
- **CI**: head SHA `787f8158344f5740a1b52e59d0c54e872f549577` has exactly
one workflow run — `CI (pull_request)`, conclusion `startup_failure`, 0
check-runs (workflow fails before launching jobs; `rocketmq-studio` branches
all show the same). Suites were therefore run locally.
- **Red-light actual output** (before the fix, same test):
```
FAIL src/pages/instance/__tests__/InstancePage.test.tsx > keeps the endpoint
editable for Apache instances but read-only for cloud vendors
Error: expect(element).toBeDisabled()
Received element is not disabled:
<input id="endpoint" aria-describedby="endpoint_extra"
aria-required="true" class="ant-input ..."
placeholder="例：proxy.mq.svc.cluster.local:8080" ...>
```
(The earlier red runs also surfaced a test-harness issue — an antd Modal in
jsdom stays in the DOM with `ant-zoom-leave` after cancel — resolved by
asserting the `ant-zoom-leave` class, the same pattern used by
`ClusterPage.test.tsx:674`.)
- **Module tests**: `npx vitest run
src/pages/instance/__tests__/InstancePage.test.tsx` → 24/24 passed after the
fix (new regression test + all 23 pre-existing).
- **Full suite + baseline**: `npx vitest run` → run 1: 945 passed, 1
unhandled-error note; run 2: 944 passed + 1 failed (`ConsumerPage > shows group
health diagnostics from subscriptions, progress and clients`, untouched file).
Isolated run of that file/test with this change applied: passed (load
flakiness; the same ConsumerPage file has been the recurring flaky file in
previous rounds).
- **Build**: `npx tsc --noEmit` clean; `npx eslint` on both changed files 0
errors/0 warnings; `npm run build` succeeded (8.24s).
- **Diff self-check** (`git show --numstat 787f8158`):
`web/src/pages/instance/index.tsx` +3/−0,
`web/src/pages/instance/__tests__/InstancePage.test.tsx` +33/−1; total 2 files,
+36/−1. No unrelated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
