RockteMQ-AI commented on code in PR #4179:
URL: 
https://github.com/apache/rocketmq-dashboard/pull/4179#discussion_r3963826127


##########
web/src/pages/instance/dlq.tsx:
##########
@@ -166,11 +166,23 @@ const DLQPage = () => {
     setGroups([]);
     setTotal(0);
     setPage(1);
+    setPageSize(20);
+    setSearch('');
     setSelectedGroupNames([]);
     setDetailGroup(null);
+    setDetailOpen(false);
+    setDetailMessages([]);
+    setDetailTotal(0);

Review Comment:
   **[Info]** Consider extracting these resets into a helper function (e.g., 
`resetDlqState()`) to avoid forgetting to reset new state variables added in 
the future. Alternatively, the `key` prop approach used in `topic.tsx` would be 
more maintainable here too — it guarantees a clean slate without manually 
listing every state setter.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to