The GitHub Actions job "CodeSpell Check" on 
rocketmq-clients.git/fix/nodejs-client-defect-fixes has failed.
Run started by GitHub user zhaohai666 (triggered by zhaohai666).

Head commit for run:
55d40b3f0907d0c11dbe529db163ea29d2d90899 / zhaohaihzb <[email protected]>
fix(nodejs): defer logger close so subclass shutdown logs do not throw

Producer#shutdown and PushConsumer#shutdown emit a final log line right after
super.shutdown(), but BaseClient#shutdown already closed the egg-logger at that
point, so every client shutdown threw "log stream had been closed" and every
integration test that tears a client down failed.

Defer the close to a setImmediate so the subclass' final log line is still
flushed before the file stream is released.

Verified against a live RocketMQ 5.5.1 broker (proxy :8081): the producer
integration suite now passes 6/6 (normal / delay / fifo / transaction send),
where previously 5 of 6 failed. Offline suite 66/66, tsc clean for both the
prod and the test config, eslint reports no errors.

Report URL: https://github.com/apache/rocketmq-clients/actions/runs/34439161218

With regards,
GitHub Actions via GitBox

Reply via email to