RockteMQ-AI commented on code in PR #11128:
URL: https://github.com/apache/rocketmq/pull/11128#discussion_r3979658500
##########
broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java:
##########
@@ -638,6 +638,12 @@ private synchronized RemotingCommand
updateAndCreateTopicList(ChannelHandlerCont
long startTime = System.currentTimeMillis();
final CreateTopicListRequestBody requestBody =
CreateTopicListRequestBody.decode(request.getBody(),
CreateTopicListRequestBody.class);
+ if (requestBody == null) {
Review Comment:
Minor inconsistency: this branch creates a new `RemotingCommand response`
via `createResponseCommand(null)`, while other methods in this PR (e.g.
`lockBatchMQ`, `unlockBatchMQ`) reuse the `response` variable already declared
above. Not wrong, but aligning the style would make the diff cleaner. Consider
moving the `response` declaration up (as done in `queryAssignment`) for
uniformity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
