unbridled-41 commented on PR #4245: URL: https://github.com/apache/rocketmq-dashboard/pull/4245#issuecomment-5638291909
## Verification evidence **CI**: This PR's head SHA `6660aa534633928af8e296a29e6cfdf2d68ab433` has exactly one workflow run — "CI" (pull_request), run id 34628315358, conclusion `startup_failure`; check-runs API returns 0. The upstream workflow has been failing at startup for all PRs in this repository (including every recently merged one), so no CI signal is available; all verification below was run locally. **Red-light actual output** (before the fix, `npx vitest run src/pages/instance/__tests__/ConsumerPage.test.tsx -t "reloads the paginated group list after creating a group"`): ``` AssertionError: expected "vi.fn()" to be called 2 times, but got 1 times Test Files 1 failed (1) Tests 1 failed | 31 skipped (32) ``` The paginated list was never re-fetched after the create succeeded. **Module tests** (after the fix): `npx vitest run src/pages/instance/__tests__/ConsumerPage.test.tsx` → `Tests 32 passed (32)` (31 pre-existing + 1 new). The pre-existing suites include single delete, batch delete, and CSV import with partial failures — all still green, pinning the delete-reload and import-row behavior this change must not break. **Full suite + baseline**: `npx vitest run` on this branch → `Test Files 1 passed (1)`... full numbers: `Tests 982 passed (982)`, **zero failures**, including the CSV-import test that exercises the reloaded import path. **Build**: `npm run build` → exit 0; `npx tsc --noEmit` clean; `npx eslint` on both changed files clean. **Diff self-check**: `git show --numstat HEAD` → `32 0 web/src/pages/instance/__tests__/ConsumerPage.test.tsx` and `9 12 web/src/pages/instance/consumer.tsx`; 2 files, +41/−12, no unrelated changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
