unbridled-41 commented on PR #4247:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4247#issuecomment-5645681340
## Verification evidence
**CI**: head `daf15d30b476e99919a8a07f14ae2b57189e761c` has exactly one
workflow run — "CI" (pull_request), id 34691862903, conclusion
`startup_failure`; check-runs: 0, combined statuses: none. The upstream
workflow fails at startup on every branch (including recent merges to
`rocketmq-studio`), so no CI signal is available for any PR; local verification
below covers the same ground (backend compile+tests, web vitest, tsc, eslint,
build).
**Red (sources stashed, new tests kept)**:
- Backend `mvn -o test
-Dtest='RocketMQAdminClientImplTest,MetadataServiceTest'` → test-compile
failure with exactly 2 errors:
`MetadataServiceTest.java:[581,14] cannot find symbol
setConsumeTps(double)` and `RocketMQAdminClientImplTest.java:[254,25] cannot
find symbol getConsumeTps()` — both on `ConsumerGroupVO`.
- Frontend `npx vitest run
src/pages/instance/__tests__/ConsumerPage.test.tsx` → `Tests 1 failed | 31
passed (32)`; the new case failed at `getByText('消费 TPS')` (column absent on
baseline).
**Green (module runs)**:
- `npx vitest run src/pages/instance/__tests__/ConsumerPage.test.tsx` →
`Test Files 1 passed (1)`, `Tests 32 passed (32)`.
- `mvn -o test -Dtest='RocketMQAdminClientImplTest,MetadataServiceTest'` →
`Tests run: 84, Failures: 0, Errors: 0` (RocketMQAdminClientImplTest 47/47,
MetadataServiceTest 37/37, each including its new case).
**Full suites + baseline comparison**:
- Backend `mvn -o test`: **2153 tests, 3 failures** —
`AuthCorsIntegrationTest.shouldStillRejectAnonymousProtectedRequests`,
`AuthCorsIntegrationTest.shouldRejectNonAdminMutationBeforeControllerExecution`,
`OpenAiCompatibleLlmGatewayTest.successfulAndFailedStreamsEmitOneTerminalSequence`
(documented load-flaky; passes isolated). Identical to the recorded baseline
failure set; zero new failures.
- Web `npx vitest run`: **982 tests, 5 failures / 4 files** — ClientsPage,
ClusterPage, InstancePage (files untouched by this change) plus 2 ConsumerPage
overload timeouts (~21s vs 2–3s isolated). Both ConsumerPage cases re-run in
isolation: `Tests 1 passed | 31 skipped (32)` each. Same load-flaky set as the
pre-existing baseline record.
**Build**: `npx tsc --noEmit` clean; eslint clean on all 7 touched web
files; `npm run build` ✓ (built in 1m 17s). Backend compiled as part of the
full `mvn -o test` run above.
**Diff self-check** (`git show daf15d30 --numstat`): 12 files, +78/−3 —
backend: ConsumerGroupVO +2, RocketMQAdminClientImpl +1, MetadataService +3/−2
(header+row columns), 2 test files +12/+19; web: metadata.ts +1,
mock/consumers.ts +11 (interface+10 demo values), consumer.tsx +10/−1 (import +
column), consumerService.ts +2 (export column + create default), 3 test files
+13/+1/+3 (fixtures + new case). No unrelated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
