unbridled-41 commented on PR #4249:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4249#issuecomment-5645766726
## Verification evidence
**CI**: head `3696930d3b8419ab67043e8f9cfebac2256785be` has exactly one
workflow run — "CI" (pull_request), id 34692651778, conclusion
`startup_failure`; check-runs not resolvable for the fork commit pre-PR and 0
on the upstream ref. The upstream workflow fails at startup on every branch
(including recent merges to `rocketmq-studio`), so no CI signal exists for any
PR; local verification below covers backend compile/test, web vitest, tsc,
eslint and build. This change is frontend-only (2 files), so the backend suite
on the TPS branch run (2153 tests, baseline failures only) reflects the shared
base.
**Red (baseline `6c24d2ed`, new tests only)**:
- `npx vitest run src/pages/instance/__tests__/TopicPage.test.tsx -t
"topic"` → `Tests 2 failed | 13 passed | 11 skipped (26)`: both new edit cases
failed at `getByRole('button', { name: /配\s*置/ })` — the row action does not
exist on baseline (error dump lists only 详情/发送/删除 buttons in the row).
- `npx vitest run src/pages/instance/__tests__/TopicPage.test.tsx -t "clean
create dialog"` → `Tests 1 failed | 25 skipped (26)` (same missing action).
**Green (module run)**:
- `npx vitest run src/pages/instance/__tests__/TopicPage.test.tsx` → `Test
Files 1 passed (1)`, `Tests 26 passed (26)` (23 pre-existing + 3 new). First
run caught one test bug (typed into the prefilled remark instead of replacing
it → assertion updated to clear-then-type; no product code change).
**Full suite + baseline comparison**:
- Full web `npx vitest run`: **984 tests, 8 failures / 7 files** (981
baseline + 3 new = 984). Failures: MetricsExplorer, ClientsPage, ClusterPage,
MessagePage, AuditPage, NotificationDeliveriesPage (files untouched by this
change — the documented load-flaky family) + 2 TopicPage cases. TopicPage
re-run in isolation immediately after: `Test Files 1 passed (1)`, `Tests 26
passed (26)` — the full run executed concurrently with `npm run build`,
matching the overload pattern recorded in previous rounds' baselines. Zero
deterministic new failures.
**Build**: `npx tsc --noEmit` clean; eslint clean on both touched files;
`npm run build` ✓ (built in 1m 21s).
**Diff self-check** (`git show 3696930d --numstat`): 2 files, +150/−13 —
`web/src/pages/instance/topic.tsx` +57/−13 (edit state/action/dialog-mode
wiring; the −13 are the create handler, modal header and row-action block
restructured to branch on edit mode) and
`web/src/pages/instance/__tests__/TopicPage.test.tsx` +93/−0 (mock key
`updateTopic` + 3 new cases). No unrelated changes, no backend files touched.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
