unbridled-41 commented on PR #4259:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4259#issuecomment-5649841906
## Verification evidence
- **CI (this head)**: run 34729592551 ("CI", `pull_request`, head
`a282cddd4a3ede6e391d332965bc9d59d05fa6bc`) — conclusion `startup_failure`,
check-runs 0. The upstream workflow fails at startup for every branch
(unapproved Docker actions, see #4136), so no CI signal is available for any
change here; local verification below covers the compile/test surface the
workflow would have run.
- **Red (actual output, on 6c24d2ed code)**:
`RocketMQMetadataProviderTest.getGroupSubscriptionsShouldReturnEmptyWhenClientReportsGroupOfflineTest`
→ `BusinessException: Failed to get subscriptions for group group-offline:
CODE: 206 DESC: Not found the consumer group connection`;
`getGroupProgressShouldReturnEmptyForBroadcastGroupTest` → `Failed to get
progress for group group-broadcast: CODE: 213 DESC: Not found the consumer
group consume stats, because return offset table is empty, the consumer is
under the broadcast mode`. Summary: `Tests run: 42, Failures: 0, Errors: 2`.
- **Module tests (after fix)**: `mvn -o test
-Dtest='RocketMQMetadataProviderTest,RocketMQAdminClientImplTest,RocketMQClientProviderTest,MetadataServiceTest'`
→ 42 + 46 + 27 + 36 = **151/151 passed**, including the pre-existing
admin-failure tests (`getGroupProgressSurfacesAdminFailure`,
`getGroupSubscriptionsSurfacesAdminFailure`) that pin genuine failures to 502.
- **Full suite + baseline**: `mvn -o test` on this branch → **2153 tests, 3
failures** (`AuthCorsIntegrationTest` ×2 — the pristine baseline pair, plus
`OpenAiCompatibleLlmGatewayTest.successfulAndFailedStreamsEmitOneTerminalSequence`
— the load-fragile case recorded in earlier rounds, passing isolated). 2153 =
baseline 2151 + 2 new regressions. Zero new failures.
- **Build**: the full run compiles main + test sources (`BUILD FAILURE` only
due to the 3 pre-existing test failures above); no separate compile errors.
- **Diff self-check**: `git show --numstat` = `RocketMQMetadataProvider.java
+13/−1`, `RocketMQMetadataProviderTest.java +29/−0`. 2 files, no unrelated
changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
