unbridled-41 commented on PR #4261:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4261#issuecomment-5649876734
## Verification evidence
- **CI (this head)**: run 34729928023 ("CI", `pull_request`, head
`78651f89d3f4b133982449356527f46ab62d2496`) — conclusion `startup_failure`,
check-runs 0. Upstream workflow fails at startup for every branch (unapproved
Docker actions, #4136); local verification below covers the compile/test
surface.
- **Red (actual output, on 6c24d2ed code)**: `RocketMQAdminClientImplTest` →
`Tests run: 49, Failures: 0, Errors: 3`:
`getConsumerGroupReturnsOfflineDetailForGroupWithoutRetryRouteTest` →
`BusinessException: Failed to get consumer group: CODE: 17 DESC: No topic
route info in name server for the topic: %RETRY%orders`;
`previewResetOffsetShouldReturnEmptyPreviewForGroupWithoutRetryRouteTest` →
`Failed to preview reset offset: CODE: 17 DESC: No topic route info in name
server for the topic: %RETRY%cg-orders`;
`previewResetOffsetShouldReturnEmptyPreviewForBroadcastGroupTest` → `Failed to
preview reset offset: CODE: 213 DESC: Not found the consumer group consume
stats, because return offset table is empty, the consumer is under the
broadcast mode`.
- **Module tests (after fix)**: `RocketMQAdminClientImplTest` 49/49,
`RocketMQMetadataProviderTest` 40/40, `RocketMQClientProviderTest` 27/27,
`MetadataServiceTest` 36/36 = **152/152 passed**.
- **Full suite + baseline**: `mvn -o test` on this branch → **2154 tests, 3
failures** = pristine baseline set
(`AuthCorsIntegrationTest.shouldRejectNonAdminMutationBeforeControllerExecution`
/ `shouldStillRejectAnonymousProtectedRequests` + load-fragile
`OpenAiCompatibleLlmGatewayTest.successfulAndFailedStreamsEmitOneTerminalSequence`);
2154 = baseline 2151 + 3 new regressions. Zero new failures.
- **Build**: full run compiles main + test sources (failure only from the 3
pre-existing test failures); checkstyle passes (initial
`UnnecessaryParentheses` violation caught and fixed before commit).
- **Diff self-check**: `git show --numstat` = `RocketMQAdminClientImpl.java
+10/−0`, `RocketMQAdminClientImplTest.java +54/−0`. 2 files, no unrelated
changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
