unbridled-41 commented on PR #4265:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4265#issuecomment-5650018819
## Verification evidence
- **CI (this head)**: run 34731226981 ("CI", `pull_request`, head
`b89fc22447e34ede56055c53f841f54a8176bb82`) — conclusion `startup_failure`,
check-runs 0. Upstream workflow fails at startup for every branch (unapproved
Docker actions, #4136); local verification below covers the compile/test/build
surface.
- **Red (actual output, on 6c24d2ed code)**: `MetricsExplorer.test.tsx >
re-runs the committed custom query when the dashboard instance changes` — the
final `waitFor` timed out because `queryMetrics` was never called a second time
for `sum(rocketmq_topic_number)` after the `instance-11 → instance-22` switch.
Summary `Tests 1 failed | 25 passed (26)`.
- **Module tests (after fix)**: `MetricsExplorer.test.tsx` **26/26 passed**,
re-run after lint-staged's prettier reformat. This includes the pre-existing
scope-drop tests (`filters query history...`, `falls back to the default source
when the selected data source leaves the instance scope`) pinning the
complementary path my guard intentionally skips.
- **Full suite + baseline**: `npx vitest run` on this branch → **982 tests,
980 passed, 2 failures**: `MetricsExplorer > restores profile, range, and
source from query history` (an existing test, ~60s timeout under load — passes
isolated within the 26/26 module run) and `ConsumerPage > shows group health
diagnostics...` (~187s, isolated **31/31** on this branch) — both belong to the
load-fragile family recorded since round 8; no failure touches the new
behavior. Baseline 6c24d2ed shows the same fragile family in this suite's full
runs.
- **Build**: `npm run build` succeeds (`✓ built in 10.74s`); `npx tsc -b`
clean; `npx eslint` clean on both touched files.
- **Diff self-check**: `git show --numstat` =
`web/src/components/MetricsExplorer.tsx +24/−0`,
`web/src/components/__tests__/MetricsExplorer.test.tsx +35/−0`. 2 files, no
unrelated changes; the fix does not touch the reload-effect lines that the open
PR #4189 modifies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
