ai-yang commented on PR #10937: URL: https://github.com/apache/rocketmq/pull/10937#issuecomment-5651386306
Pushed follow-up commit f3901017f89509118835cd90b40109b3b51aa9c3 to complete the shared-accumulator lifecycle fix. The guard reference count alone did not isolate pending batches: a running producer could join a batch retaining an already stopped producer. Aggregation keys now include the concrete producer identity (also for explicit queues and same-group replacement instances). Completion/failure releases held bytes once and removes only that completed batch, avoiding stale producer retention. Validation: 53 targeted client tests passed (5 accumulator + 41 producer + 7 new lifecycle cases), with Checkstyle and SpotBugs enabled. The seven new cases produced six failures against the previous PR production classes and all passed with this follow-up. The description documents the deterministic test setup and the autoBatch=false default. @guyinyou, could you review the new batch ownership and cleanup semantics when convenient? In particular, producer isolation deliberately trades cross-producer coalescing for lifecycle correctness; no throughput improvement or graceful draining of a stopped producer is claimed. CI on this new head is separate from the earlier green result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
