RockteMQ-AI commented on code in PR #11155:
URL: https://github.com/apache/rocketmq/pull/11155#discussion_r4001830681
##########
common/src/main/java/org/apache/rocketmq/common/message/Message.java:
##########
@@ -98,10 +99,12 @@ public void putUserProperty(final String name, final String
value) {
this.putProperty(name, value);
}
+ @Nullable
Review Comment:
**[Info]** The `@Nullable` annotations are correctly applied to all seven
getters that can legitimately return null. This improves IDE support and Kotlin
interop without changing runtime behavior.
One minor note: `javax.annotation.Nullable` is from JSR-305 (legacy). Modern
Java projects sometimes prefer `org.jetbrains.annotations.Nullable` or
`@org.checkerframework.checker.nullness.qual.Nullable`, but
`javax.annotation.Nullable` is widely recognized and works well with Kotlin's
null-safety. No action needed.
##########
common/pom.xml:
##########
@@ -67,6 +67,12 @@
<dependency>
<groupId>io.opentelemetry</groupId>
<artifactId>opentelemetry-exporter-otlp</artifactId>
+ <exclusions>
Review Comment:
**[Info]** The okhttp exclusion is well-targeted. Since RocketMQ uses the
gRPC exporter (`opentelemetry-exporter-otlp` with gRPC transport), the HTTP
sender (`okhttp`) is unused and was pulling `kotlin-stdlib` transitively into
pure-Java consumers.
This mirrors the existing `okio-jvm` exclusion pattern in the root pom and
keeps the dependency tree clean for Java-only deployments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
