lizhimins commented on PR #4166: URL: https://github.com/apache/rocketmq-dashboard/pull/4166#issuecomment-5679164696
Thanks for spotting that the config preview call has no request-id guard — you're right that it is a different call site from the broker/nameserver diff guards we merged earlier, so this isn't a duplicate. We're closing it because the reachable impact is display-only. `configPreview` never feeds the write path: `handleConfigSubmit` rebuilds the request from the form values, so a late preview cannot cause a wrong update. Mainline also clears the preview on modal open, on cancel, and on any form value change, so the only residual window is "cancel and reopen for another cluster while a preview is still in flight", and the next keystroke wipes it. Finally, this would be the fourth hand-rolled request-id ref in this file; we'd rather extract one shared helper and apply it to all four call sites at once. A PR that does that extraction would be very welcome. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
