lizhimins commented on PR #4121: URL: https://github.com/apache/rocketmq-dashboard/pull/4121#issuecomment-5694490966
Closing together with #4118, which changes the same collector for the same `-1` sentinel six minutes earlier; we will land one trunk-side fix covering max-queue lag, per-topic backlog and the delay clamp at `ApacheRocketMqBusinessMetricsCollector.java:123`. Separately, this patch has a semantic regression we could not accept as written: `resolveLag` (`RocketMQAdminClientImpl.java:1003`) is shared by three call sites, and routing a computed negative difference through `ConsumerLagResolver.resolve(diff, null)` changes what the other two report, not just the metric sample. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
