yyqdbngt commented on PR #4085:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4085#issuecomment-5693696785
Rebased onto the current `rocketmq-studio` head (`1e8cc591`) and re-verified.
The only conflict was the import block in
`web/src/pages/home/dashboard.tsx`: the base had gained `import type {
ColumnsType } from 'antd/es/table';`, while this branch added
`DownloadOutlined` to the `@ant-design/icons` import. Both sides were kept.
Two test expectations had drifted with the base and are fixed in the same
commit:
- the cluster name now also renders in the traffic-insights card, so the
render wait uses `findAllByText('apache-cluster')`;
- the instance filter is addressed by its accessible name `实例筛选` (the JSON
`aria-label` of the antd `Select`), matching the other tests in the file.
Verification on the rebased head:
- `npx vitest run src/pages/home/__tests__/DashboardPage.test.tsx` → 9
passed, including `exports the cluster summary table as CSV for the selected
instance` and `uses "all" in the CSV filename when no instance is selected`.
- `npx eslint` on `dashboard.tsx` and the test file → clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
