lizhimins opened a new pull request, #4380:
URL: https://github.com/apache/rocketmq-dashboard/pull/4380
### Which Issue(s) This PR Fixes
- Refs #4379
### Brief Description
`master` is now the RocketMQ Studio trunk, so the configuration that GitHub
and ASF
infrastructure only read from the **default branch** has to move with it:
- **`.asf.yaml`** — copied verbatim from the previous `master` (`770822bbc`,
now archived on
`master_archive`), so squash-only merging and the
`[email protected]` /
`[email protected]` notification routing stay exactly as they were.
Without this file on
the default branch the Studio trunk has no ASF repository settings.
- **`.github/workflows/stale.yml`** — copied verbatim from the previous
`master`. Scheduled
workflows only run from the default branch, so the 7-day stale bot is
currently not running
and stays off until this lands.
- **`.github/workflows/ci.yml`** — `on.push.branches` and
`on.pull_request.branches` change from
the deleted `rocketmq-studio` to `master`; otherwise CI never triggers
again. The CI-only
frontend image tag also drops the retired branch name:
`rocketmq-studio-web-ci:latest` → `rocketmq-studio-web:ci`.
No application code is touched.
### How Did You Test This Change?
Configuration-only change, verified by parsing and by reading the repository
back through the API:
- All three files parse: `python3 -c "import yaml; yaml.safe_load(open(p))"`
for `.asf.yaml`,
`.github/workflows/stale.yml` and `.github/workflows/ci.yml`. The parsed
triggers are
`{'push': {'branches': ['master']}, 'pull_request': {'branches':
['master']}}` and
`{'schedule': [{'cron': '0 0 * * *'}]}`.
- The carried-over files are byte-identical to the ones on the archived
`master`:
`diff <(git show 770822bbc:.asf.yaml) .asf.yaml` and the same for
`stale.yml` are both empty.
(The legacy `develop` branch also had an `.asf.yaml`, but it is the 2021
version and lacks the
whole `notifications:` block, which is why the `master` copy is the one
carried over.)
- The CI trigger change was observed live: updating `master` produced a
`CI [master] event=push` workflow run, so the workflow is picked up on the
new trunk. That run
ends in `startup_failure`, as does every other run in this repository — a
pre-existing,
repo-wide problem, not something this change introduces.
- No `${{ github.event.* }}` value is interpolated into any shell step; the
only expression in
these workflows is `concurrency.group: ci-${{ github.ref }}`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
